[Asterisk-code-review] Expand the scope of Dial Events (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Expand the scope of Dial Events
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/2791/1/UPGRADE.txt
File UPGRADE.txt:

Line 26:  - The policy for when to send "Dial" events has changed. Previously, "Dial"
formatting should be the same as other entries.


https://gerrit.asterisk.org/#/c/2791/1/main/bridge_channel.c
File main/bridge_channel.c:

Line 2441: 			ast_channel_publish_dial(NULL, bridge_channel->chan, NULL, controls[frame->subclass.integer]);
I think publishing the forwarding, busy, congestion, etc events is going to have side effects on the basic bridge attended transfer.  Does the DTMF atxfer generate the start/end events when dialing the transfer target?


https://gerrit.asterisk.org/#/c/2791/1/main/cdr.c
File main/cdr.c:

PS1, Line 1907: 	return (strcmp(dialstatus, "RINGING") &&
              : 			strcmp(dialstatus, "PROCEEDING") &&
              : 			strcmp(dialstatus, "PROGRESS"));
Should look for a positive dial end status like CANCEL or ANSWER rather than it is ended by process of elimination.


https://gerrit.asterisk.org/#/c/2791/1/main/manager_channels.c
File main/manager_channels.c:

PS1, Line 1066: 	return (strcmp(dialstatus, "RINGING") &&
              : 			strcmp(dialstatus, "PROCEEDING") &&
              : 			strcmp(dialstatus, "PROGRESS"));
same here about process of elimination


-- 
To view, visit https://gerrit.asterisk.org/2791
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42cbec7730d84640a434d143a0d172a740995543
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes