[Asterisk-code-review] res pjsip: Add test for Endpoint IP Access Controls feature (testsuite[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip: Add test for Endpoint IP Access Controls feature
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Unfortunately I think we'll have to reduce the scope of this test a lot. Unfortunately on different platforms the use of additional loopback addresses doesn't work as you'd expect. While you can bind the source address of the packets actually end up being 127.0.0.1 and not of the different loopback address. This has happened on our CentOS Jenkins nodes I believe.

https://gerrit.asterisk.org/#/c/2818/1/tests/channels/pjsip/acl_call/configs/ast1/extconfig.conf
File tests/channels/pjsip/acl_call/configs/ast1/extconfig.conf:

Line 2: acls => sqlite3,asterisk,acltable
Why the use of sqlite in this test? All other tests use config files primarily.


https://gerrit.asterisk.org/#/c/2818/1/tests/channels/pjsip/acl_call/run-test
File tests/channels/pjsip/acl_call/run-test:

Line 1: #!/usr/bin/env python
This can all be done using a test-config.yaml file instead these days, which is much preferred as it is easier to manage and read. There are quite a few examples of using SIPp scenarios from one. I just put one up even.


-- 
To view, visit https://gerrit.asterisk.org/2818
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie95e035a960c497b8497021205401b1df589eae9
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes