[Asterisk-code-review] datastore: Add common container based datastores API. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: datastore: Add common container based datastores API.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/2777/2/include/asterisk/datastore.h
File include/asterisk/datastore.h:

Line 102: struct ao2_container *ast_datastores_alloc(void);
> Instead of hard coding the number of buckets to always be the same value fo
I sway back and forth on it, when it comes to datastores there's really no intelligent value for bucket size which is why I just kept it fixed for all.


-- 
To view, visit https://gerrit.asterisk.org/2777
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72eb15941dcdbc2a37bb00a33ce00f8755bd336a
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes