[Asterisk-code-review] res pjsip empty: Add test for reply to empty SIP INFO packets (testsuite[master])
Joshua Colp
asteriskteam at digium.com
Mon May 9 05:25:30 CDT 2016
Joshua Colp has posted comments on this change.
Change subject: res_pjsip_empty: Add test for reply to empty SIP INFO packets
......................................................................
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.asterisk.org/#/c/2788/1/tests/channels/pjsip/info_empty/configs/ast1/pjsip.conf
File tests/channels/pjsip/info_empty/configs/ast1/pjsip.conf:
PS1, Line 27: ;; test2
:
: [test2](endpoint_t)
: aors=test2
:
: [test2](aor_t)
: contact=sip:test2 at 127.0.0.1:5062
This can be removed, only test is needed.
https://gerrit.asterisk.org/#/c/2788/1/tests/channels/pjsip/info_empty/sipp/empty.xml
File tests/channels/pjsip/info_empty/sipp/empty.xml:
Line 67: 0
Any reason why these are in it? You sort of end up crafting INFO messages with content, but without content.
https://gerrit.asterisk.org/#/c/2788/1/tests/channels/pjsip/info_empty/test-config.yaml
File tests/channels/pjsip/info_empty/test-config.yaml:
Line 4: Tests INFO packets with no Content-Type are responded to.
Describe what the test does in more detail. Example:
This test establishes a call to Asterisk and once established sends INFO messages without content (no Content-Type header). The empty INFO module should respond to each with a 200 OK.
--
To view, visit https://gerrit.asterisk.org/2788
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7999582041be32e359940be731972ba9387bb397
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: snuffy <snuffy22 at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list