[Asterisk-code-review] res pjsip authenticator digest: Don't use source port in non... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip_authenticator_digest: Don't use source port in nonce verification
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2770/1/res/res_pjsip_authenticator_digest.c
File res/res_pjsip_authenticator_digest.c:

PS1, Line 213: 	ast_copy_pj_str(ast_str_buffer(str), &rdata->msg_info.cid->id,
             : 			pj_strlen(&rdata->msg_info.cid->id) + 1);
I don't think using the Call-ID is viable here since there is no requirement for the next request after being challenged to use it. This has come up a few times in the past.


-- 
To view, visit https://gerrit.asterisk.org/2770
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I871b5f4adce102df1c4988066283095ec509dffe
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes