[Asterisk-code-review] res pjsip empty info: Respond to empty SIP INFO packets (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip_empty_info: Respond to empty SIP INFO packets
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

This should also have an entry in CHANGES added. If you'd like it to go into 13 it should have a test to verify it works. Since there's already an INFO DTMF test it should be pretty easy to use that as a base, minus the DTMF part.

https://gerrit.asterisk.org/#/c/2710/3//COMMIT_MSG
Commit Message:

Line 15: 
This should have the issue and #close tag


https://gerrit.asterisk.org/#/c/2710/3/res/res_pjsip_empty_info.c
File res/res_pjsip_empty_info.c:

Line 35: static void send_response(struct ast_sip_session *session, 
Be gone redness!


PS3, Line 50: 	if (!session->channel) {
            : 		return 0;
            : 	}
Since this doesn't do anything on the channel you're safe to remove this check.


-- 
To view, visit https://gerrit.asterisk.org/2710
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib27e4f07151e5aef28fa587e4ead36c5b87c43e0
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: snuffy <snuffy22 at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: snuffy <snuffy22 at gmail.com>
Gerrit-HasComments: Yes