[Asterisk-code-review] translate: Enables native Packet-Loss Concealment (PLC) for ... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: translate: Enables native Packet-Loss Concealment (PLC) for supporting codecs.
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.asterisk.org/#/c/1820/9/main/translate.c
File main/translate.c:

Line 637: 			while (current != inner && AST_LIST_NEXT(current, frame_list)) {
> Mhm. The last frame was not calculated before, because it was the last fram
You are adding new frames to the end of the list.  Simply remember the last frame you added to the list so you do not have to walk the list to find the last frame in the list.  If this is the first time through the list then the last frame would be NULL and likely this would be the first frame in the list anyway.


-- 
To view, visit https://gerrit.asterisk.org/1820
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfcf0670e094e9718d82fd9920f1fb2dae122006
Gerrit-PatchSet: 9
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes