[Asterisk-code-review] res fax/t38 gateway: Peer V.21 session is created on wrong c... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_fax/t38_gateway: Peer V.21 session is created on wrong channel
......................................................................


Patch Set 1:

(3 comments)

What scenario was this uncovered in that caused a problem?

https://gerrit.asterisk.org/#/c/2744/1/res/res_fax.c
File res/res_fax.c:

Line 2862: 		ast_log(LOG_ERROR, "Cann't create V21 session on chan %s for T.38 gateway session\n", ast_channel_name(chan));
Can't


Line 3361: 			ast_log(LOG_ERROR, "Cann't create V21 session on chan %s for T.38 gateway session\n", ast_channel_name(peer));
Can't


PS1, Line 3491:     	if (global_fax_debug) {
              :         	details->option.debug = AST_FAX_OPTFLAG_TRUE;
              :     	}
In the future I'd suggest having side stuff like this be a separate review. That way if something comes up it's not held up.


-- 
To view, visit https://gerrit.asterisk.org/2744
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78387156ea521a77eb0faf170179ddd37a50430e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes