[Asterisk-code-review] app voicemail: always copy dynamic struct to avoid race cond... (asterisk[13])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change.

Change subject: app_voicemail: always copy dynamic struct to avoid race condition
......................................................................


Patch Set 11: Code-Review+2

(2 comments)

https://gerrit.asterisk.org/#/c/2433/11/apps/app_voicemail.c
File apps/app_voicemail.c:

Line 6688: 			free_user(vmu);
I wonder if this is a potential free_user() leak...


Line 11026: 		ast_play_and_wait(chan, "vm-goodbye");
free_user()?


-- 
To view, visit https://gerrit.asterisk.org/2433
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a0643813116da84e2617291903d0d489b7425fb
Gerrit-PatchSet: 11
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Andrew Nagy <andrew.nagy at the159.com>
Gerrit-Reviewer: Andrew Nagy <andrew.nagy at the159.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes