[Asterisk-code-review] translate: Re-enables native Packet-Loss Concealment (PLC) f... (asterisk[master])

[Jaco Kroon]

Jaco Kroon has posted comments on this change.

Change subject: translate: Re-enables native Packet-Loss Concealment (PLC) for supporting codex.
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.asterisk.org/#/c/1820/10/main/translate.c
File main/translate.c:

Line 565: 		if (current->seqno != path->f.seqno && path->f.seqno < 0x10000) {
Other than in newpvt I don't see that pvt->f.seqno ever gets updated.  As such the new code will never take effect.  Is this an oversight in the previous patches or does this get updated elsewhere (that I cannot find in main/translate.c)?  Basically if I'm not mistaken path->f.seqno will remain 0x10000 forever and never queue any "empty" frames for PLC.


-- 
To view, visit https://gerrit.asterisk.org/1820
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfcf0670e094e9718d82fd9920f1fb2dae122006
Gerrit-PatchSet: 10
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes