[Asterisk-code-review] ARI: Add method to Dial a created channel. (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Thu Mar 31 12:06:11 CDT 2016


Richard Mudgett has posted comments on this change.

Change subject: ARI: Add method to Dial a created channel.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/2514/1/res/ari/resource_channels.c
File res/ari/resource_channels.c:

Line 1630: 		ast_channel_cleanup(caller);
Looks like you are unreffing caller too many times.  RAII_VAR getting in the way?


https://gerrit.asterisk.org/#/c/2514/1/res/stasis/control.c
File res/stasis/control.c:

Line 1161: 	return;
extraneous return


-- 
To view, visit https://gerrit.asterisk.org/2514
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6c399c791e66c4aa52454222fe4f8b02483a205
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list