[Asterisk-code-review] config: fix flags in uint option handler (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Thu Mar 24 11:12:30 CDT 2016


Richard Mudgett has posted comments on this change.

Change subject: config: fix flags in uint option handler
......................................................................


Patch Set 2: Code-Review-1

There is one more location that needs fixing:
diff --git a/apps/app_skel.c b/apps/app_skel.c                                                          
index 337539e..3da3db0 100644                                                                           
--- a/apps/app_skel.c                                                                                   
+++ b/apps/app_skel.c                                                                                   
@@ -739,7 +739,7 @@ static int load_module(void)                                                        
                                                                                                        
        /* Level options */                                                                                                                                                                                    
        aco_option_register(&cfg_info, "max_number", ACO_EXACT, level_options, NULL, OPT_UINT_T, 0, FLDSET(struct skel_level, max_num));
-       aco_option_register(&cfg_info, "max_guesses", ACO_EXACT, level_options, NULL, OPT_UINT_T, 1, FLDSET(struct skel_level, max_guesses));
+       aco_option_register(&cfg_info, "max_guesses", ACO_EXACT, level_options, NULL, OPT_UINT_T, 0, FLDSET(struct skel_level, max_guesses));
 
        if (aco_process_config(&cfg_info, 0) == ACO_PROCESS_ERROR) {
                goto error;

-- 
To view, visit https://gerrit.asterisk.org/2445
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96b539336275e0e72a8e8033487d2c3344debd3e
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Gianluca Merlo <gianluca.merlo at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list