[Asterisk-code-review] Fix Failing atxfer fail blond test (testsuite[master])

[Mark Michelson]

Hello Richard Mudgett, Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/2434

to look at the new patch set (#2).

Change subject: Fix Failing atxfer_fail_blond test
......................................................................

Fix Failing atxfer_fail_blond test

There were two issues here:

First, the TALK_DETECTED variable was not being set by BackgroundDetect.
This was because the audio being transmitted by Alice was going to Bob
but not being echoed back to Alice. This is fixed by adjusting Bob's
dialplan to use Echo() instead of Wait().

Second, the automatic recall feature for attended transfers was not
working properly for this test. The problem with the recall is that it's
possible to call a specific SIP endpoint, but it's not possible to know
what username to call at that endpoint. So when attempting to recall
Alice, an INVITE gets sent to an Asterisk instance but there is no way
for the Asterisk server to know where in the dialplan to send the call.
This is fixed by simply removing the recall. The test is not intending
to even test the recall, but to ensure that in a failed blond transfer
that all channels are properly hung up.

Change-Id: I8c4175c3abd1cc1d2e71f3a73c3a11ea17436452
---
M configs/bridge/ast1/features.conf
M configs/bridge/ast2/extensions.conf
M configs/bridge/ast3/extensions.conf
M lib/python/asterisk/bridge_test_case.py
M tests/bridge/atxfer_fail_blonde/test-config.yaml
5 files changed, 6 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/34/2434/2
-- 
To view, visit https://gerrit.asterisk.org/2434
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c4175c3abd1cc1d2e71f3a73c3a11ea17436452
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>