[Asterisk-code-review] res pjsip/pjsip options: Fix From generation on outgoing OP... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip/pjsip_options:  Fix From generation on outgoing OPTIONS
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/2373/6/res/res_pjsip.c
File res/res_pjsip.c:

Line 2916: 	fromuser = endpoint ? (!ast_strlen_zero(endpoint->fromuser) ? endpoint->fromuser : ast_sorcery_object_get_id(endpoint)) : NULL;
This differs from the behavior of the rest of things by using the endpoint ID here. It also assumes that the endpoint ID itself is valid/somehow important for the From username. I don't think that will always be true and don't see how it's important...


https://gerrit.asterisk.org/#/c/2373/6/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

Line 341: 		endpoint_local = find_an_endpoint(contact);
Why do you need to always find the endpoint here? We actually only care about if we get a response or not, not what the response is. Why does it matter if the From username is not the endpoint from_user or the endpoint ID?


-- 
To view, visit https://gerrit.asterisk.org/2373
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2207e12bb435e373bd1e03ad091d82e5aba011af
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes