[Asterisk-code-review] hep.conf.sample: Default 'enabled' to 'no' (asterisk[13])

Anonymous Coward asteriskteam at digium.com
Wed Jun 29 18:10:00 CDT 2016


Anonymous Coward #1000019 has submitted this change and it was merged.

Change subject: hep.conf.sample: Default 'enabled' to 'no'
......................................................................


hep.conf.sample: Default 'enabled' to 'no'

Following the principle of least surprise, we should not be sending
massive numbers of PJSIP and RTCP HEP packets out into the ether to some
only-slightly-random IP address. Having 'enabled' set to 'no' in the
sample configuration file should prevent this from happening for those
who run 'make samples'.

ASTERISK-26159 #close

Change-Id: I1753a64ca83a3442a6ebdc31061f8185c062d9b1
---
M configs/samples/hep.conf.sample
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Sean Bright: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved



diff --git a/configs/samples/hep.conf.sample b/configs/samples/hep.conf.sample
index 6e409d1..e1cd52e 100644
--- a/configs/samples/hep.conf.sample
+++ b/configs/samples/hep.conf.sample
@@ -4,7 +4,7 @@
 
 ; All settings are currently set in the general section.
 [general]
-enabled = yes                      ; Enable/disable forwarding of packets to a
+enabled = no                       ; Enable/disable forwarding of packets to a
                                    ; HEP server. Default is "yes".
 capture_address = 192.168.1.1:9061 ; The address of the HEP capture server.
 capture_password = foo             ; If specified, the authorization passsword

-- 
To view, visit https://gerrit.asterisk.org/3107
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1753a64ca83a3442a6ebdc31061f8185c062d9b1
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>



More information about the asterisk-code-review mailing list