[Asterisk-code-review] res pjsip: fix PJSIP tests to comply with ASTERISK-26061 (testsuite[master])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change.

Change subject: res_pjsip: fix PJSIP tests to comply with ASTERISK-26061
......................................................................


Patch Set 1:

> Because these tests now depend on your changes, they're going to
 > fail on other branches like certified/13.1 and certified/13.8. 
 > You'll need to add version-specific config sections with minversion
 > and maxversion.
 > 
 > The original section would have a minversion of 13.0.0 and a
 > maxversion of 13.11.0 and your new section would have a minversion
 > of 13.11.0.  There are other examples in tests/channels/pjsip.

The 13.1-cert7 skipped both patched tests because of version dependency:
 * channels/pjsip/config_wizard/phone - Minimum Version: 13.2.0
 * rest_api/applications/subscribe-all - Minimum Version: 13.7.0

The 13.8-cert1-rc3 with pjproject-2.5 passed both patched tests.
--> tests/channels/pjsip/config_wizard/phone --- PASSED
--> tests/rest_api/applications/subscribe-all --- PASSED

The 13.8-cert1-rc3 with pjproject-2.4.5 passed both patched tests.
--> tests/channels/pjsip/config_wizard/phone --- PASSED
--> tests/rest_api/applications/subscribe-all --- PASSED

The 13.8-cert1-rc3 with bundled pjproject passed both patched tests.
--> tests/channels/pjsip/config_wizard/phone --- PASSED
--> tests/rest_api/applications/subscribe-all --- PASSED

I've also tested

version 13.2.0 with pjproject-2.5
 * channels/pjsip/config_wizard/phone - passed
 * rest_api/applications/subscribe-all - skipped

version 13.7.0 with pjproject-2.5 don't start because of deprecated pjsip_dlg_create_uas

version 13.7.0 with pjproject-2.4.5
--> tests/channels/pjsip/config_wizard/phone --- PASSED
--> tests/rest_api/applications/subscribe-all --- FAILED
ari:775 on_stop: Expected 1 <= count <= 1; was 2 ({'peer': {'peer_status': 'Reachable'}, 'application': 'testsuite', 'endpoint': {'technology': 'PJSIP', 'state': 'online', 'resource': 'alice'}, 'type': 'PeerStatusChange'}, !None)
This is because of 
https://issues.asterisk.org/jira/browse/ASTERISK-25137
https://issues.asterisk.org/jira/browse/ASTERISK-25116
which was fixed in 13.8

The patched tests can't failed because of this patch.

-- 
To view, visit https://gerrit.asterisk.org/3091
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb824331c26b88d77e5b653efd51498bba039f04
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No