[Asterisk-code-review] Implement deaf mode for confbridge (asterisk[master])

[Timo Teräs]

Timo Teräs has posted comments on this change.

Change subject: Implement deaf mode for confbridge
......................................................................


Patch Set 3:

(2 comments)

Fixed other points.

https://gerrit.asterisk.org/#/c/2933/3/apps/app_confbridge.c
File apps/app_confbridge.c:

Line 1149: static void test_suite_feature_action_event_notify(
> This should be made a macro as ast_test_suite_event_notify() is also a macr
Is this really necessary? When TEST_FRAMEWORK is not defined, ast_test_suite_event_notify() expands to nothing. Compiler is then smart enough to see that this function is empty, and can optimize it out.


Line 1871: 		user.features.deaf = 1;
> The bridge core does not need to have a special deaf mode as you just need 
It seems the bridge's suspend mode also disables incoming audio so it would also mute the channel. The idea of deaf mode is to be able to speak, but not hear anything.

My use case is to have speaker phones that work as microphone only.


-- 
To view, visit https://gerrit.asterisk.org/2933
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2628bdda080fd2b1e914212de50dd26de9d3e96
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Timo Teräs <timo.teras at iki.fi>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Timo Teräs <timo.teras at iki.fi>
Gerrit-HasComments: Yes