[Asterisk-code-review] res rtp asterisk: fix memory leak in dtls (asterisk[11])
Torrey Searle
asteriskteam at digium.com
Tue Jun 21 06:59:13 CDT 2016
Torrey Searle has uploaded a new change for review.
https://gerrit.asterisk.org/3051
Change subject: res_rtp_asterisk: fix memory leak in dtls
......................................................................
res_rtp_asterisk: fix memory leak in dtls
ASTERISK-26129 ensure that cert bios get freed after creating the fingerprint
Change-Id: I44d23aea07dce80176ca1ff877c5ace9452ef451
---
M res/res_rtp_asterisk.c
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/51/3051/1
diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c
index 86595a3..023dbe4 100644
--- a/res/res_rtp_asterisk.c
+++ b/res/res_rtp_asterisk.c
@@ -1334,7 +1334,7 @@
if (!ast_strlen_zero(dtls_cfg->certfile)) {
char *private = ast_strlen_zero(dtls_cfg->pvtfile) ? dtls_cfg->certfile : dtls_cfg->pvtfile;
BIO *certbio;
- X509 *cert;
+ X509 *cert = NULL;
const EVP_MD *type;
unsigned int size, i;
unsigned char fingerprint[EVP_MAX_MD_SIZE];
@@ -1376,6 +1376,9 @@
ast_log(LOG_ERROR, "Could not produce fingerprint from certificate '%s' for RTP instance '%p'\n",
dtls_cfg->certfile, instance);
BIO_free_all(certbio);
+ if (cert) {
+ X509_free(cert);
+ }
return -1;
}
@@ -1387,6 +1390,7 @@
*(local_fingerprint-1) = 0;
BIO_free_all(certbio);
+ X509_free(cert);
}
if (!ast_strlen_zero(dtls_cfg->cipher)) {
--
To view, visit https://gerrit.asterisk.org/3051
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44d23aea07dce80176ca1ff877c5ace9452ef451
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
More information about the asterisk-code-review
mailing list