[Asterisk-code-review] astfd: With RLIMIT NOFILE only the current value is sensible. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: astfd: With RLIMIT_NOFILE only the current value is sensible.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2968/1/main/astfd.c
File main/astfd.c:

Line 279: 	ast_cli(a->fd, "Current maxfiles: %d\n", (int) rl.rlim_cur);
> It is believed that RLIM_INFINITY is not possible for RLIMIT_NOFILE. If you
I think that the RLIMIT_INFINITY check needs to remain based upon the man pages I've seen.  It would just mean that no limit has been set on the number of files you can open.


-- 
To view, visit https://gerrit.asterisk.org/2968
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49cf7952d73aec9e3f6a88942842c39be18380fa
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes