[Asterisk-code-review] configure: Avoid obsolete warnings on autoconf. (asterisk[13])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: configure: Avoid obsolete warnings on autoconf.
......................................................................


Patch Set 1:

> https://wiki.asterisk.org/wiki/display/AST/Commit+Messages

I know the link to the guidelines. I understand that you do not like my commit message. OK. However, I do not know what you are looking for, what you are expecting:
A) Should I write buildtools: instead of configure:?
B) Should I make up a description? What shall I put into that description? I changed AC_HELP_STRING into AS_HELP_STRING, which was added with autoconf 2.58 (May 2003). Asterisk requires autoconf 2.59. Removed AC_FUNC_SETVBUF_REVERSED and AC_TYPE_SIGNAL because Asterisk requires ANSI C. Replaced the libcurl.m4 and pthread.m4 with upstream versions.

> provide analysis of each of the obsolete options that were removed and what their probable impact would be.

First of all, I do not have any benefit of that change itself. I found this while debugging an issue with PJSIP. I reported this to all affected projects including Asterisk merely to train patching. AC_TYPE_SIGNAL is obsolete when C89 or better is used. AC_FUNC_SETVBUF_REVERSED was required for the SVR2 environment from 1983, which is obsolete since 1987. I am referring to the documentation of autoconf about obsolete macros here. What else did I remove? If something is suspicious, I can remove that from the patch set.

-- 
To view, visit https://gerrit.asterisk.org/2885
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4512b40a1087a6cc2d90b461ccfd33a9ca4906e3
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No