[Asterisk-code-review] translate: Enables native Packet-Loss Concealment (PLC) for ... (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: translate: Enables native Packet-Loss Concealment (PLC) for supporting codecs.
......................................................................


Patch Set 12: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1820/12/main/translate.c
File main/translate.c:

PS12, Line 591: framein(p, &missed);
Giving a -1 because this approach overloads the buffers of codec modules.
translate.c:417 framein: Out of buffer space
Although no byte-data is stored, the buffer is checked by the amount of samples added to the codec module. Some codec modules have a storage of 200 milliseconds. Therefore, after around 10 lost frames, the stream would be interrupted.


-- 
To view, visit https://gerrit.asterisk.org/1820
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfcf0670e094e9718d82fd9920f1fb2dae122006
Gerrit-PatchSet: 12
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes