[Asterisk-code-review] app voicemail: Add taskprocessor alert level options. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: app_voicemail: Add taskprocessor alert level options.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/3318/3/apps/app_voicemail.c
File apps/app_voicemail.c:

Line 14036: 				ast_log(AST_LOG_WARNING, "Invalid the taskprocessor high water alert trigger level '%s'. Using default value.\n", val);
> I think in case of embedded system is can be lower.
I don't think allowing the high level to be 0 is a good thing.  The code checking the high level is likely to react badly to that.

As to a memory limited embedded system, I don't think the LOW_MEMORY menuselect option has been tested in quite awhile.  I haven't seen any patches associated with that option.


-- 
To view, visit https://gerrit.asterisk.org/3318
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I766294fbffedf64053c0d9ac0bedd3109f043ee8
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes