[Asterisk-code-review] codecs: Add iLBC 20. (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: codecs: Add iLBC 20.
......................................................................


Patch Set 3:

That code parts and the commit message are as intended. Rationale:
In both cases, ‘default’ means internal ‘fallback value’. When there was no ‘mode=’ value, iLBC 30 should be used, because iLBC 20 was introduced later, and some legacy applications do not know/send/parse a format attribute ‘mode=’ at all. Only if both parties stated ‘mode=20’, iLBC 20 should be used. Asterisk starts the conversation with ‘mode=20’ and replies to ‘mode=20’ with ‘mode=20’. Or stated differently: The external default is iLBC 20. The internal default (fallback) is iLBC 30.

-- 
To view, visit https://gerrit.asterisk.org/3253
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07f523a3aa1338bb5217a1bf69c1eeb92adedffa
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No