[Asterisk-code-review] realtime: Improve test compatibility. (testsuite[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: realtime: Improve test compatibility.
......................................................................


Patch Set 2:

(1 comment)

Your changes to astconfigparser.py should also be made in the Asterisk repo's contrib/scripts/sip_to_pjsip/astconfigparser.py

https://gerrit.asterisk.org/#/c/3214/2/tests/channels/pjsip/configuration/duplicate_sections/test-config.yaml
File tests/channels/pjsip/configuration/duplicate_sections/test-config.yaml:

Line 31:         - configuration
I suggest a different name for this added tag. I suggest something like "skip-realtime" so that the same tag can be used across multiple PJSIP tests and it's clear that the intention is so that the test does not run in realtime mode.


-- 
To view, visit https://gerrit.asterisk.org/3214
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibff2af1c0c4bce28b94360aecec5996f363b4ae8
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes