[Asterisk-code-review] pjproject: fixed a few bugs (asterisk[13])
Joshua Colp
asteriskteam at digium.com
Wed Jul 20 12:58:08 CDT 2016
Joshua Colp has posted comments on this change.
Change subject: pjproject: fixed a few bugs
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.asterisk.org/#/c/3254/3/third-party/pjproject/patches/0001-pjproject-pjsip_tx_data_dec_ref.patch
File third-party/pjproject/patches/0001-pjproject-pjsip_tx_data_dec_ref.patch:
PS3, Line 9: + if (!atomic_var) {
: + return -1;
: + }
> It happens when dialog has been already destroyed.
Then I believe that problem should be identified further and fixed, instead of patching around it like this.
--
To view, visit https://gerrit.asterisk.org/3254
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b05917c93d993f95d604c042ace5f1a5500f59a
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list