[Asterisk-code-review] pbx: Create pbx ignorepat.c for management of 'struct ast ig... (asterisk[master])

Corey Farrell asteriskteam at digium.com
Mon Jul 18 02:26:52 CDT 2016


Hello Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/3213

to look at the new patch set (#5).

Change subject: pbx: Create pbx_ignorepat.c for management of 'struct ast_ignorepat'.
......................................................................

pbx: Create pbx_ignorepat.c for management of 'struct ast_ignorepat'.

This changes context ignore patterns from a linked list to a vector,
makes 'struct ast_ignorepat' opaque to pbx.c.

Although ast_walk_context_ignorepats is maintained the procedure is no
longer efficient except for the first call (inc==NULL).  This
functionality is replaced by two new functions implemented by vector
macros.
* ast_context_ignorepats_count (AST_VECTOR_SIZE)
* ast_context_ignorepats_get (AST_VECTOR_GET)

As with ast_walk_context_ignorepats callers of these functions are
expected to have locked contexts.  Only a few places in Asterisk walked
the ignorepats, they have been converted to use the new functions.

Change-Id: I78f2157d275ef1b7d624b4ff7d770d38e5d7f20a
---
M include/asterisk/pbx.h
M main/pbx.c
A main/pbx_ignorepat.c
M main/pbx_private.h
M pbx/pbx_config.c
M res/ael/pval.c
M utils/conf2ael.c
M utils/extconf.c
8 files changed, 233 insertions(+), 117 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/13/3213/5
-- 
To view, visit https://gerrit.asterisk.org/3213
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78f2157d275ef1b7d624b4ff7d770d38e5d7f20a
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019



More information about the asterisk-code-review mailing list