[Asterisk-code-review] rest api/channels: Updates for create dial bridge (testsuite[master])

Anonymous Coward asteriskteam at digium.com
Wed Jul 13 05:40:02 CDT 2016


Anonymous Coward #1000019 has submitted this change and it was merged.

Change subject: rest_api/channels: Updates for create_dial_bridge
......................................................................


rest_api/channels: Updates for create_dial_bridge

Change-Id: Ie13ce93492631fa0c6249a3cb486614dfa4b6ad0
---
M tests/rest_api/channels/create_dial_bridge/dial/nominal/basic/test-config.yaml
M tests/rest_api/channels/create_dial_bridge/dial/nominal/continue/test-config.yaml
M tests/rest_api/channels/create_dial_bridge/dial/off-nominal/test-config.yaml
3 files changed, 5 insertions(+), 28 deletions(-)

Approvals:
  Mark Michelson: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved



diff --git a/tests/rest_api/channels/create_dial_bridge/dial/nominal/basic/test-config.yaml b/tests/rest_api/channels/create_dial_bridge/dial/nominal/basic/test-config.yaml
index bd75d43..1f66714 100644
--- a/tests/rest_api/channels/create_dial_bridge/dial/nominal/basic/test-config.yaml
+++ b/tests/rest_api/channels/create_dial_bridge/dial/nominal/basic/test-config.yaml
@@ -67,15 +67,10 @@
                 channel:
                     id: 'channel1'
             count: 1
-        ari-requests:
-            -   method: 'delete'
-                uri: 'channels/channel1'
-                expect: 204
 
     -   ari-events:
             match:
-                type: 'ChannelHangupRequest'
-                cause: 32
+                type: 'StasisEnd'
                 application: 'testsuite'
                 channel:
                     id: 'channel1'
@@ -83,7 +78,7 @@
 
     -   ari-events:
             match:
-                type: 'StasisEnd'
+                type: 'ChannelDestroyed'
                 application: 'testsuite'
                 channel:
                     id: 'channel1'
diff --git a/tests/rest_api/channels/create_dial_bridge/dial/nominal/continue/test-config.yaml b/tests/rest_api/channels/create_dial_bridge/dial/nominal/continue/test-config.yaml
index c7f3e9c..5a08d6f 100644
--- a/tests/rest_api/channels/create_dial_bridge/dial/nominal/continue/test-config.yaml
+++ b/tests/rest_api/channels/create_dial_bridge/dial/nominal/continue/test-config.yaml
@@ -84,21 +84,8 @@
 
     -   ari-events:
             match:
-                type: 'ChannelHangupRequest'
+                type: 'ChannelDestroyed'
                 cause: 99
-                application: 'testsuite'
-                channel:
-                    id: 'channel1'
-            count: 1
-        ari-requests:
-            -   method: 'delete'
-                uri: 'channels/channel1'
-                expect: 204
-
-    -   ari-events:
-            match:
-                type: 'ChannelHangupRequest'
-                cause: 32
                 application: 'testsuite'
                 channel:
                     id: 'channel1'
diff --git a/tests/rest_api/channels/create_dial_bridge/dial/off-nominal/test-config.yaml b/tests/rest_api/channels/create_dial_bridge/dial/off-nominal/test-config.yaml
index 4a624cc..4bd3524 100644
--- a/tests/rest_api/channels/create_dial_bridge/dial/off-nominal/test-config.yaml
+++ b/tests/rest_api/channels/create_dial_bridge/dial/off-nominal/test-config.yaml
@@ -119,15 +119,10 @@
                 channel:
                     id: 'channel1'
             count: 1
-        ari-requests:
-            -   method: 'delete'
-                uri: 'channels/channel1'
-                expect: 204
 
     -   ari-events:
             match:
-                type: 'ChannelHangupRequest'
-                cause: 32
+                type: 'StasisEnd'
                 application: 'testsuite'
                 channel:
                     id: 'channel1'
@@ -135,7 +130,7 @@
 
     -   ari-events:
             match:
-                type: 'StasisEnd'
+                type: 'ChannelDestroyed'
                 application: 'testsuite'
                 channel:
                     id: 'channel1'

-- 
To view, visit https://gerrit.asterisk.org/3177
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie13ce93492631fa0c6249a3cb486614dfa4b6ad0
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>



More information about the asterisk-code-review mailing list