[Asterisk-code-review] PJSIP: provide valid tcp nodelay option for reuse (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: PJSIP: provide valid tcp nodelay option for reuse
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/3151/1/res/res_pjsip/config_transport.c
File res/res_pjsip/config_transport.c:

Line 565: 		static int option = 1;
It isn't obvious that this needs to be static when reading the code.  Unless you look up the commit message you wouldn't know why it needs to be static.

A comment saying that a pointer to option is saved by the lower routines would be helpful.


-- 
To view, visit https://gerrit.asterisk.org/3151
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3251164c7f710dbdab031282f00e30a9770626a0
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes