[Asterisk-code-review] channels/chan sip: 180 Ringing not sent after 183 Session Pr... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: channels/chan_sip: 180 Ringing not sent after 183 Session Progress
......................................................................


Patch Set 1: Code-Review-1

I agree with Matt on the potential implications of doing this in a release version. Changing behavior should never be taken lightly, even if it may seem right. The real world may not agree. I think the path of making this configurable somehow is the right way so it will allow your scenario to work, but not impact others. If future real world testing shows that changing the default is fine then we can explore that.

-- 
To view, visit https://gerrit.asterisk.org/1696
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I498fed853128831b80536f8818cd7b60e641f39c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Morten Tryfoss <morten at tryfoss.no>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Morten Tryfoss <morten at tryfoss.no>
Gerrit-Reviewer: Olle Johansson <oej at edvina.net>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No