[Asterisk-code-review] chan sip.c: AMI & CLI notify methods get different values of... (asterisk[11])

[Joshua Colp]

Hello Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/2128

to look at the new patch set (#2).

Change subject: chan_sip.c: AMI & CLI notify methods get different values of asterisk's own ip.
......................................................................

chan_sip.c: AMI & CLI notify methods get different values of asterisk's own ip.

When I ask asterisk to send a SIP NOTIFY message to a sip peer using either a)
AMI action: SIPnotify or b) cli command: sip notify <cmd> <peer>, I expect
asterisk to include the same value for its own ip in both cases a) and b),
but it seems a) produces a contact header like Contact:
<sip:asterisk at 192.168.1.227:8060> whereas b) produces a contact header like
<sip:asterisk at 127.0.0.1:8060>. 0.0.0.0:8060 is my udpbindaddr in sip.conf

My guess is that manager_sipnotify should call
ast_sip_ouraddrfor(&p->sa, &p->ourip, p) the same way sip_cli_notify does,
because after applying this patch, both cases a) and b) produce
the contact header that I expect: <sip:asterisk at 192.168.1.227:8060>

Reported by: Stefan Engström
Tested by: Stefan Engström

Change-Id: I86af5e209db64aab82c25417de6c768fb645f476
---
M channels/chan_sip.c
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/28/2128/2
-- 
To view, visit https://gerrit.asterisk.org/2128
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I86af5e209db64aab82c25417de6c768fb645f476
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Stefan Engström <stefanen at kth.se>
Gerrit-Reviewer: Anonymous Coward #1000019