[Asterisk-code-review] manager sipnotify and sip cli notify have different logic w.... (asterisk[master])

[Stefan Engström]

Stefan Engström has posted comments on this change.

Change subject: manager_sipnotify and sip_cli_notify have different logic w.r.t setting own ip
......................................................................


Patch Set 1:

I noticed that when sending sip notifys through cli and through AMI action SIPnotify produce different results with respect to which asterisk-ip is used in the outgoing sip message. 

When my sip.conf binds to 0.0.0.0 then SIP notify through CLI produces a contact header with ...asterisk at 192.168.1.227... and through AMI i get ...asterisk at 127.0.0.1... so I took a quick look at the chan_sip.c and with this ticket I want to question why those two functions behave differently.

-- 
To view, visit https://gerrit.asterisk.org/2126
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86af5e209db64aab82c25417de6c768fb645f476
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Stefan Engström <stefanen at kth.se>
Gerrit-Reviewer: Stefan Engström <stefanen at kth.se>
Gerrit-HasComments: No