[Asterisk-code-review] chan sip: fixed ice candidate as media address when specified (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: chan_sip: fixed ice candidate as media_address when specified
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Thanks for the patch!

The comments I have below are all due to coding guideline infractions and are relatively minor. In the future, you may want to review the coding guidelines when contributing a patch back.

https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines

https://gerrit.asterisk.org/#/c/2085/1/channels/chan_sip.c
File channels/chan_sip.c:

Line 12708: 		if (  !ast_sockaddr_isnull(&media_address)  ) {
Coding guidelines: don't add extraneous spaces:

if (!ast_sockaddr_isnull(&media_address)) {


Line 12710: 		}
          : 		else {
Coding guidelines: braces need to be on the same line:

} else {


Line 12715: 			ast_str_append(a_buf, 0, "%s typ ", ast_sockaddr_stringify_port(&candidate->address));
Coding guidelines: This line appears to be indented too far.


-- 
To view, visit https://gerrit.asterisk.org/2085
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I352dfc76096ef4d742f14f869ecd620d4b2c8fd6
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Fabrizio Lombardozzi <fabrizio.lombardozzi at sociale.it>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes