[Asterisk-code-review] main/asterisk.c: ast el read char (asterisk[master])

[Diederik de Groot]

Diederik de Groot has posted comments on this change.

Change subject: main/asterisk.c: ast_el_read_char
......................................................................


Patch Set 3:

(1 comment)

Reply:

https://gerrit.asterisk.org/#/c/2032/3/main/asterisk.c
File main/asterisk.c:

Line 2705: 				if (write(STDOUT_FILENO, "\r", 5) < 0) {
> This is very old code.  Hazarding a guess, I'd say that it is to prevent co
bit of an ugly method of doing that, but ok (i guess). We could start by adding it to the previous if, and save one if. Then again if we can't write to stdout, we might want to produce an error an give up.


-- 
To view, visit https://gerrit.asterisk.org/2032
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd7f691310815a31756b76067c56fba299d3ae9
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes