[Asterisk-code-review] main/asterisk.c: ast el read char (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: main/asterisk.c: ast_el_read_char
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

This patch will need to be cherry picked to v11 and v13 since it was found in v11.

https://gerrit.asterisk.org/#/c/2032/1//COMMIT_MSG
Commit Message:

Line 12: ASTERISK-24801
Line should be:
ASTERISK-24801 #close


https://gerrit.asterisk.org/#/c/2032/1/main/asterisk.c
File main/asterisk.c:

Line 2711: 			if ((res < EL_BUF_SIZE - 1) && ((res >= 1 && buf[res-1] == '\n') || (res >= 2 && buf[res-2] == '\n'))) {
The check for res >= 1 is not needed.  A check earlier guarantees res >= 1.


-- 
To view, visit https://gerrit.asterisk.org/2032
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd7f691310815a31756b76067c56fba299d3ae9
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes