[Asterisk-code-review] RFC: Add global pluggable modules. (testsuite[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: RFC: Add global pluggable modules.
......................................................................


Patch Set 6:

If I understand, every test that runs will load all pluggable global module(s) correct? I'm not sure if I like that. Seems like it could potentially cause problems for a test that doesn't even make use of the module itself. Unless that is what you were thinking when you talked about adding an opt-in option. Meaning a particular global module won't load unless the test opts-in.

I wonder too if the module itself really needs to be global or just the configuration? If we are going to have to have each test opt-in why not just make it a regular plugggable module. Each test could then specify specific configuration information if it needed too. If none existed it could pull the configuration from the global config by default.

Even with some kind of opt-in mechanism don't we still need a way to run the tests in different ways (one with config files the other realtime)? Without a command line option how are we going to tell the testsuite to run the tests using a different back end? Unless I am misunderstanding something.

-- 
To view, visit https://gerrit.asterisk.org/1803
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec1b1cfa48cadab108c4ab65122ce36ab697e4e
Gerrit-PatchSet: 6
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No