[Asterisk-code-review] res musiconhold: Prevent multiple simultaneous reloads. (asterisk[master])

[Sean Bright]

Sean Bright has uploaded a new change for review.

  https://gerrit.asterisk.org/2002

Change subject: res_musiconhold: Prevent multiple simultaneous reloads.
......................................................................

res_musiconhold: Prevent multiple simultaneous reloads.

There are two ways in which the reload() function in res_musiconhold can be
called from the CLI:

  * module reload res_musiconhold.so
  * moh reload

In the former case, the module loader holds a lock that prevents multiple
concurrent calls, but in the latter there is no such protection.

This patch changes the 'moh reload' CLI command to invoke the module loader
directly, rather than call reload() explicitly.

Change-Id: I408968b4c8932864411b7f9ad88cfdc7b9ba711c
---
M res/res_musiconhold.c
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/02/2002/1

diff --git a/res/res_musiconhold.c b/res/res_musiconhold.c
index bf7635e..4e50563 100644
--- a/res/res_musiconhold.c
+++ b/res/res_musiconhold.c
@@ -1808,7 +1808,8 @@
 	if (a->argc != e->args)
 		return CLI_SHOWUSAGE;
 
-	reload();
+	/* The module loader will prevent concurrent reloads from occurring, so we delegate */
+	ast_module_reload("res_musiconhold");
 
 	return CLI_SUCCESS;
 }

-- 
To view, visit https://gerrit.asterisk.org/2002
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I408968b4c8932864411b7f9ad88cfdc7b9ba711c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>