[Asterisk-code-review] RFC: Add runtime option that allows automatic realtime execu... (testsuite[master])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: RFC: Add runtime option that allows automatic realtime execution.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/1803/3/lib/python/asterisk/test_config.py
File lib/python/asterisk/test_config.py:

Line 386:         if not self.config:
        :             return
You shouldn't have to check for empty here; this method is called from _parse_config, which is called from __init__. 

In _parse_config (a semi-private method), we already check for empty self.config and prevent any further processing if self.config is determined to have no value.

See line 398.


-- 
To view, visit https://gerrit.asterisk.org/1803
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec1b1cfa48cadab108c4ab65122ce36ab697e4e
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes