[Asterisk-code-review] res pjsip: Create human friendly serializer names. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: res_pjsip: Create human friendly serializer names.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/1958/2/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

Line 1109: * \since 13.8.0
         :  *
         :  * See \ref ast_threadpool_serializer for more information on serializers.
         :  * SIP creates serializers so that tasks operating on similar data will run
         :  * in sequence.
         :  *
         :  * \param name Name of the serializer. (must be unique)
         :  *
         :  * \retval NULL Failure
         :  * \retval non-NULL Newly-created serializer
         :  */
         : struct ast_taskprocessor *ast_sip_create_serializer(const char *name);
         : 
         : struct ast_serializer_shutdown_group;
         : 
         : /*!
         :  * \brief Create a new serializer for SIP tasks
         :  * \since 13.8.0
         :  *
         :  * See \ref ast_threadpool_serializer for more information on serializers.
         :  * SIP creates serializers so that tasks operating on similar data will run
         :  * in sequence.
         :  *
         :  * \param name Name of the serializer. (must be unique)
         :  * \param shutdown_group Group shutdown controller. (NULL if no group association)
         :  *
         :  * \retval NULL Failure
         :  * \retval non-NULL Newly-created serializer
         :  */
         : struct ast_taskprocessor *ast_sip_create_serializer_group(const char *name, struct ast_serializer_shutdown_group *shutdown_group);
Do we care about backwards compatibility here? Should we add a new function instead of changing the current signature?


-- 
To view, visit https://gerrit.asterisk.org/1958
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9df8da3ddae1132cb2ef65f64df0c465c5e084
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes