[Asterisk-code-review] Sorcery: Create human friendly serializer names. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Mon Jan 11 13:32:54 CST 2016


Joshua Colp has posted comments on this change.

Change subject: Sorcery: Create human friendly serializer names.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/1957/2/main/sorcery.c
File main/sorcery.c:

Line 860: 	ast_taskprocessor_build_name(tps_name, sizeof(tps_name), "sorcery/%s", type);
> Including the module name results in names that are way too long which get 
At least "global" will likely end up getting duped if we use sorcery in another module, that's my fear.


-- 
To view, visit https://gerrit.asterisk.org/1957
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc2e5d3dbab15c825b97c38c028319a0d2315c47
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list