[Asterisk-code-review] cdr/originate-cdr-disposition: Fix ordering of SIP messages ... (testsuite[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: cdr/originate-cdr-disposition: Fix ordering of SIP messages in scenario
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/1894/1/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-timeout.xml
File tests/cdr/originate-cdr-disposition/sipp/wait-for-call-timeout.xml:

Line 54:         CSeq: 102 INVITE
> Does the cseq need to be saved from the INVITE for it to be correct?
Since chan_sip is in use it's predictable, if that were to ever change (doubtful) then saving it from previous would be wise. I think we're fine here though.


-- 
To view, visit https://gerrit.asterisk.org/1894
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I955b15b488881835b7dd39b6b34cd35c3fb233fd
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes