[Asterisk-code-review] apps/playback: Add a remote uri test for Playback of remote ... (testsuite[master])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: apps/playback: Add a remote_uri test for Playback of remote media files
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/2316/2/lib/python/asterisk/http_static_server.py
File lib/python/asterisk/http_static_server.py:

Line 29:         reactor.listenTCP(module_config.get('port', 80), server.Site(root))
Can I suggest not making the default port 80?
Maybe 8090 like one of the later tests.


-- 
To view, visit https://gerrit.asterisk.org/2316
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I606d700efded1afd2b25f97fba1808dc7a14c8ea
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes