[Asterisk-code-review] Restrict CLI/AMI commands on shutdown. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: Restrict CLI/AMI commands on shutdown.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

> > Are these crashes possible when using graceful shutdown or is
 > this
 > > just an issue with fast shutdown?  I'm interested in knowing some
 > > details about the crashes this fixes.
 > 
 > I don't know off the top of my head the answer to this. This was
 > found by some Digium internal stress tests that are based on the
 > open source testsuite. I know that the testsuite has a tiered
 > shutdown procedure, where it tries a graceful shutdown initially
 > and then moves to shutting down now if the graceful shutdown does
 > not succeed after a certain time. I'm not sure if the crash
 > scenarios had escalated to a now shutdown or not. I will attempt to
 > find out if the logs are helpful for this.

If it's using the normal testsuite shutdown procedure it's actually 'core stop gracefully', if that times out it uses 'kill -9'.  So these issues are likely during graceful shutdown.  This likely means the CLI unregister failed because the command was being executed by another thread.

https://gerrit.asterisk.org/#/c/2283/1/main/cli.c
File main/cli.c:

Line 2702
I think this increment needs to be done with &helpers locked to prevent a race between execute and unregister.


-- 
To view, visit https://gerrit.asterisk.org/2283
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f5b8e665bd4d0108014a8b6589729ecd3677eef
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes