[Asterisk-code-review] Fix coordinated transfer failures. (testsuite[master])

[Mark Michelson]

Mark Michelson has uploaded a new change for review.

  https://gerrit.asterisk.org/2258

Change subject: Fix coordinated transfer failures.
......................................................................

Fix coordinated transfer failures.

Scenarios that use SIPp's third party call control contain a coordinated
receiver scenario. This scenario opens a TCP port over which other
scenarios can send commands. Sometimes these tests will fail because the
coordinated scenario will not have its TCP port open by the time that
other scenarios are attempting to send commands.

This commit fixes the problem by using the '-sleep' SIPp command line
option in order to delay the start of scenarios that may be dependent on
the coordinated receiver scenario.

Change-Id: I6840a5a5d644e70b0f90b675e303c383926abb48
---
M tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/test-config.yaml
M tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_blonde/test-config.yaml
M tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/test-config.yaml
M tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_blonde/test-config.yaml
4 files changed, 10 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/58/2258/1

diff --git a/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/test-config.yaml b/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/test-config.yaml
index e296325..db6fcc6 100644
--- a/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/test-config.yaml
+++ b/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local/test-config.yaml
@@ -25,10 +25,10 @@
     test-iterations:
         -
             scenarios:
-                - { 'coordinated-sender': {'key-args': {'scenario':'referer_uas.xml', '-p':'5066'} },
+                - { 'coordinated-sender': {'key-args': {'scenario':'referer_uas.xml', '-p':'5066', '-sleep': '2'} },
                     'coordinated-receiver': { 'key-args': {'scenario':'referee.xml', '-p':'5065'} } }
-                - { 'key-args': {'scenario':'uas.xml', '-p':'5067'} }
-                - { 'key-args': {'scenario':'uac-no-hangup.xml', '-p':'5068', '-s':'alice'} }
+                - { 'key-args': {'scenario':'uas.xml', '-p':'5067', '-sleep': '2'} }
+                - { 'key-args': {'scenario':'uac-no-hangup.xml', '-p':'5068', '-s':'alice', '-sleep': '2'} }
 
 ami-config:
     -
diff --git a/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_blonde/test-config.yaml b/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_blonde/test-config.yaml
index 3154c80..4aa6673 100644
--- a/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_blonde/test-config.yaml
+++ b/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_blonde/test-config.yaml
@@ -31,10 +31,10 @@
     test-iterations:
         -
             scenarios:
-                - { 'coordinated-sender': {'key-args': {'scenario':'referer_uas.xml', '-p':'5066'} },
+                - { 'coordinated-sender': {'key-args': {'scenario':'referer_uas.xml', '-p':'5066', '-sleep': '2'} },
                     'coordinated-receiver': { 'key-args': {'scenario':'referee.xml', '-p':'5065'} } }
-                - { 'key-args': {'scenario':'uas.xml', '-p':'5067'} }
-                - { 'key-args': {'scenario':'uac-no-hangup.xml', '-p':'5068', '-s':'alice'} }
+                - { 'key-args': {'scenario':'uas.xml', '-p':'5067', '-sleep': '2'} }
+                - { 'key-args': {'scenario':'uac-no-hangup.xml', '-p':'5068', '-s':'alice', '-sleep': '2'} }
 
 ami-config:
     -
diff --git a/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/test-config.yaml b/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/test-config.yaml
index 4bf00e1..30a0598 100644
--- a/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/test-config.yaml
+++ b/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local/test-config.yaml
@@ -30,7 +30,7 @@
         -
             scenarios:
                 - { 'key-args': {'scenario':'uas.xml', '-p':'5067', '-m':'2'} }
-                - { 'coordinated-sender': {'key-args': {'scenario':'referer.xml', '-p':'5066'} },
+                - { 'coordinated-sender': {'key-args': {'scenario':'referer.xml', '-p':'5066', '-sleep': '2'} },
                     'coordinated-receiver': {'key-args': {'scenario':'referee.xml', '-p':'5065'} } }
 
 ami-config:
diff --git a/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_blonde/test-config.yaml b/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_blonde/test-config.yaml
index 4096f96..58fbe69 100644
--- a/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_blonde/test-config.yaml
+++ b/tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_blonde/test-config.yaml
@@ -34,9 +34,9 @@
     test-iterations:
         -
             scenarios:
-                - { 'key-args': {'scenario':'uas.xml', '-p':'5067', '-m':'2'} }
-                - { 'key-args': {'scenario':'uas_hangup.xml', '-p':'5068', '-m':'2'} }
-                - { 'coordinated-sender': {'key-args': {'scenario':'referer.xml', '-p':'5066'} },
+                - { 'key-args': {'scenario':'uas.xml', '-p':'5067', '-m':'2', '-sleep': '2'} }
+                - { 'key-args': {'scenario':'uas_hangup.xml', '-p':'5068', '-m':'2', '-sleep': '2'} }
+                - { 'coordinated-sender': {'key-args': {'scenario':'referer.xml', '-p':'5066', '-sleep': '2'} },
                     'coordinated-receiver': {'key-args': {'scenario':'referee.xml', '-p':'5065'} } }
 
 ami-config:

-- 
To view, visit https://gerrit.asterisk.org/2258
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6840a5a5d644e70b0f90b675e303c383926abb48
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>