[Asterisk-code-review] Fix creation race of contact status structures. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Mon Feb 15 13:17:43 CST 2016


Joshua Colp has posted comments on this change.

Change subject: Fix creation race of contact_status structures.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/2250/1/res/res_sorcery_memory.c
File res/res_sorcery_memory.c:

Line 105: 	existing = ao2_find(data, ast_sorcery_object_get_id(object), OBJ_KEY);
Use options and OBJ_NOLOCK here to prevent recursive locking.


Line 112: 	ao2_link(data, object);
Same here.


-- 
To view, visit https://gerrit.asterisk.org/2250
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55b1460ff1eb0af0a3697b82d7c2bac9f6af5b97
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list