[Asterisk-code-review] Realtime: Add contacts and subscription persistence. (testsuite[master])
Mark Michelson
asteriskteam at digium.com
Tue Feb 2 15:01:27 CST 2016
Mark Michelson has uploaded a new change for review.
https://gerrit.asterisk.org/2149
Change subject: Realtime: Add contacts and subscription persistence.
......................................................................
Realtime: Add contacts and subscription persistence.
A comment stated that these two object types did not add much value when
doing automatic realtime conversion since they were write-only and were
not the source for actual configuration.
As it turns out, it is quite useful to have tests where these use
realtime. Specifically, a regression that was introduced in Asterisk
13.7.0 would have been caught by CI if contacts were being stored in
realtime.
This commit adds these write-only object types to realtime conversion
since there is benefit to having tests with these object types being
configured for realtime.
Change-Id: I7356f25521e69e807908034cf8e7a8b0e67afdb4
---
M lib/python/asterisk/realtime_converter.py
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/49/2149/1
diff --git a/lib/python/asterisk/realtime_converter.py b/lib/python/asterisk/realtime_converter.py
index 87bef09..8aec232 100644
--- a/lib/python/asterisk/realtime_converter.py
+++ b/lib/python/asterisk/realtime_converter.py
@@ -324,12 +324,8 @@
# We don't include the following object types in this dictionary:
# * system
# * transport
- # * contact
- # * subscription_persistence
# The first two don't work especially well for dynamic realtime since they
- # are not reloadable. contact and subscription_persistence are left out
- # because they are write-only and so there should be no configuration
- # items for those.
+ # are not reloadable.
#
# The table names here are the ones that the alembic scripts use.
{
@@ -339,12 +335,16 @@
'auth': 'ps_auths',
'global': 'ps_globals',
'domain_alias': 'ps_domain_aliases',
+ 'contact': 'ps_contacts',
},
'res_pjsip_endpoint_identifier_ip': {
'identify': 'ps_endpoint_id_ips',
},
'res_pjsip_outbound_registration': {
'registration': 'ps_registrations',
- }
+ },
+ 'res_pjsip_pubsub': {
+ 'subscription_persistence': 'ps_subscription_persistence'
+ },
}
))
--
To view, visit https://gerrit.asterisk.org/2149
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7356f25521e69e807908034cf8e7a8b0e67afdb4
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
More information about the asterisk-code-review
mailing list