[Asterisk-code-review] bridge native rtp.c: Minor code cleanups. (asterisk[master])

Martin Tomec asteriskteam at digium.com
Wed Dec 28 04:15:22 CST 2016


Martin Tomec has posted comments on this change. ( https://gerrit.asterisk.org/4680 )

Change subject: bridge_native_rtp.c: Minor code cleanups.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Looks good to me. I have only small hint, but I am not sure if temp variable is better...

https://gerrit.asterisk.org/#/c/4680/1/bridges/bridge_native_rtp.c
File bridges/bridge_native_rtp.c:

PS1, Line 363: ast_rtp_instance_get_engine(instance0)
Could there be a temporary variable instead of calling ast_rtp_instance_get_engine()? 
It could be shorter and more readable then.


-- 
To view, visit https://gerrit.asterisk.org/4680
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65bc5732aa7c9a2537f062f106fbea711cf2daad
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Martin Tomec <tomec.martin at gmail.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list