[Asterisk-code-review] MESSAGE: Flush Message/ast msg queue channel alert pipe. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4621 )

Change subject: MESSAGE: Flush Message/ast_msg_queue channel alert pipe.
......................................................................


Patch Set 1:

> For message channels what is causing things to get queued like this
 > in the first place?

The Hangup() application will put a null frame into the queue to wake up a normal channel.  For the Message/ast_msg_queue channel nothing reads the queue.  If you don't put Hangup() at the end of your message processing, you'll get an "Auto fallthrough" message logged.

Hangup() likely isn't the only application to do something like this but I think most of those are likely also dealing with media and shouldn't be used when processing out-of-dialog messages.

-- 
To view, visit https://gerrit.asterisk.org/4621
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id54baa57a8dbca84e29f28bcd2ffc0a5ac12d8b2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No