[Asterisk-code-review] chan sip: Reorder unload module to deal with stuck TCP threads. (asterisk[master])

[Michael Kuron]

Michael Kuron has posted comments on this change. ( https://gerrit.asterisk.org/4615 )

Change subject: chan_sip: Reorder unload_module to deal with stuck TCP threads.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

After I fixed one double free issue, this patch passed my test scenario. Otherwise the code looks good. Once that issue is fixed, I think this can be merged.

https://gerrit.asterisk.org/#/c/4615/1/channels/chan_sip.c
File channels/chan_sip.c:

Line 35465: 	io_context_destroy(io);
This needs to be replaced with:

       if (io) {
               io_context_destroy(io);
               io = NULL;
       }

Otherwise we get a double free crash when attempting module unload a second time.


-- 
To view, visit https://gerrit.asterisk.org/4615
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie23692041d838fbd35ece61868f4c640960ff882
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Michael Kuron <m.kuron at gmx.de>
Gerrit-HasComments: Yes