[Asterisk-code-review] pjsip/ami: Add test for PJSIPShowRegistrationInboundContactS... (testsuite[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4573 )

Change subject: pjsip/ami: Add test for PJSIPShowRegistrationInboundContactStatuses
......................................................................


Patch Set 1: Code-Review-1

(6 comments)

https://gerrit.asterisk.org/#/c/4573/1//COMMIT_MSG
Commit Message:

Line 7: pjsip/ami: Add test for PJSIPShowRegistrationInboundContactStatuses
Should be referencing the ASTERISK issue.


https://gerrit.asterisk.org/#/c/4573/1/tests/channels/pjsip/ami/show_registration_inbound_contact_statuses/test-config.yaml
File tests/channels/pjsip/ami/show_registration_inbound_contact_statuses/test-config.yaml:

Line 8:     minversion: '13.14.0'
Probably should start using this format for mid-series test additions:
['13.14.0', '14.3.0']


Line 30:     reactor-timeout: 15
Is it necessary to shorten the default reactor timeout?


Line 47:             count: '>1'
Shouldn't there be only one of these events.


Line 69:             count: '>1'
Shouldn't there be only one of these events.


Line 95:             count: '>1'
Shouldn't there be only one of these events.


-- 
To view, visit https://gerrit.asterisk.org/4573
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46b1bb328de6024dec925775cade5d9646729ec6
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes