[Asterisk-code-review] tests/channels/pjsip/statsd/registrations: Fix shutdown (testsuite[master])

[Anonymous Coward]

Anonymous Coward #1000019 has submitted this change and it was merged. ( https://gerrit.asterisk.org/4549 )

Change subject: tests/channels/pjsip/statsd/registrations: Fix shutdown
......................................................................


tests/channels/pjsip/statsd/registrations: Fix shutdown

Increasing the shutdown timeout allows us to now get events we couldn't
get before because they were cut off due to Asterisk being forcibly
killed.

Note: If a machine were fast enough this test might have failed because we
would actually get the events that were suppressed before.

* Add statsd events we couldn't get before.

ASTERISK-26527 #close

Change-Id: Ic20f1826c267348d345d762e283d6d10891393aa
---
M tests/channels/pjsip/statsd/registrations/test-config.yaml
1 file changed, 5 insertions(+), 6 deletions(-)

Approvals:
  George Joseph: Looks good to me, approved
  Joshua Colp: Verified



diff --git a/tests/channels/pjsip/statsd/registrations/test-config.yaml b/tests/channels/pjsip/statsd/registrations/test-config.yaml
index 5a0c2f2..434d996 100644
--- a/tests/channels/pjsip/statsd/registrations/test-config.yaml
+++ b/tests/channels/pjsip/statsd/registrations/test-config.yaml
@@ -5,7 +5,7 @@
         the expected StatsD statistics are generated as a result.'
 
 properties:
-    minversion: '13.7.0'
+    minversion: ['13.14.0', '14.3.0']
     dependencies:
         - python: 'twisted'
         - python: 'starpy'
@@ -29,11 +29,6 @@
 
 statsd-config:
     prefix: 'PJSIP.registrations'
-    # Note that we will never see the count get decremented, nor the
-    # last Unregistered state get decremented, as Asterisk sends an
-    # un-REGISTER on shutdown that we can't intercept. The processing
-    # of that un-REGISTER would trigger the previously mentioned
-    # counts.
     packets:
         -
             'PJSIP.registrations.count:0|g'
@@ -55,6 +50,10 @@
             'PJSIP.registrations.state.Registered:-1|g'
         -
             'PJSIP.registrations.state.Unregistered:+1|g'
+        -
+            'PJSIP.registrations.count:-1|g'
+        -
+            'PJSIP.registrations.state.Unregistered:-1|g'
 
 test-object-config:
     fail-on-any: False

-- 
To view, visit https://gerrit.asterisk.org/4549
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic20f1826c267348d345d762e283d6d10891393aa
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>